(RHEL-44630) netif-naming-scheme: disable NAMING_BRIDGE_MULTIFUNCTION_SLOT #283
Conversation
github-actions
bot
changed the title
github-actions
bot
added
tracker/unapproved
Commit validationTracker - RHEL-44630 The following commits meet all requirements
Tracker validationSuccess🟢 Tracker RHEL-44630 has set desired product: Pull Request validationSuccess🟢 CI - All checks have passed Auto MergeSuccess🟢 Pull Request is not marked as draft and it's not blocked by |
github-actions
bot
added
tracker/missing
There was a problem hiding this comment.
I don't like the wording of the manpage paragraph. It is difficult to understand in my opinion so I've tried to rewrite it for better clarity
Never generate a slot name when a PCI bridge is detected.
Since version "rhel-9.0", we have generated slot-based names for PCI multifunction devices, because we assumed that it is enough to use function numbers to distinguish between devices. However, name conflict can occur if these devices are not children of the same PCI bridge, e.g. there are multiple PCI bridges in the same slot.
This effectively reverts 66425da. The commit assumes that if the network interface has multifunctions, then the function fields of the pci devices under the same PCI bridge device are unique. But it seems not, at least on some setups. See issue #28929. Let's revert the change, and always refuse to set slot base naming if a PCI bridge is detected. Fixes #28929. (cherry picked from commit af7417a) Resolves: RHEL-44630
github-actions
bot
added
pr/needs-ci
|
You are missing |
Good catch thanks! #284 |
This effectively reverts 66425da.
The commit assumes that if the network interface has multifunctions, then the function fields of the pci devices under the same PCI bridge device are unique.
But it seems not, at least on some setups. See issue #28929. Let's revert the change, and always refuse to set slot base naming if a PCI bridge is detected.
Fixes #28929.
(cherry picked from commit af7417a)
Resolves: RHEL-44630